What is best, metal or poly tanks?

It will depends on personal preference, Metal tanks are used more where space is an issue, as they are custom made, in most cases a tank can be made to fit a site. Also sometimes comes down to looks, some customers prefer the look of corrugated metal tanks over poly.